On Wed, 21 Nov 2018, Daniel Kiper wrote: > On Tue, Nov 20, 2018 at 10:45:04AM +0000, Lee Jones wrote: > > From: Lee Jones <lee.jo...@linaro.org> > > > > arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’ > > > > Without this fix, building xen_boot.c omits: > > > > loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’: > > loader/arm64/xen_boot.c:370:7: error: too few arguments to function > > ‘grub_create_loader_cmdline’ > > grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from loader/arm64/xen_boot.c:36:0: > > ../include/grub/lib/cmdline.h:29:12: note: declared here > > grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf, > > > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > > Pushed despite it had malformed tabs. Next time please use "git format-patch" > and "git send-email" to build and send the patches.
I normally do this (for my kernel work), but Leif asked me to reply directly to this mail (since I am not set-up for Grub). If I continue to contribute, I'll set something up more enduring. Thank you for your help. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel