On Fri, Apr 13, 2018 at 11:36:49PM +0200, Olaf Hering wrote: > With --disable-nls no locales exist. > > Avoid runtime error by moving code that copies locales into its own > function. Return early in case nls was disabled. That way the compiler > will throw away unreachable code, no need to put preprocessor > conditionals everywhere to avoid warnings about unused code. > > Fix memleak by freeing dstf.
s/dstf/srcf and dstf/? > Convert tabs to spaces in moved code. > > Signed-off-by: Olaf Hering <o...@aepfle.de> Otherwise LGTM. If there are no objections I will commit this patch in a week or so. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel