On Fri, Feb 23, 2018 at 03:51:07PM +0100, Daniel Kiper wrote: > On Wed, Feb 21, 2018 at 03:20:27PM -0500, Peter Jones wrote: > > This basically moves a bunch of the section information we pass around a > > lot into a struct, and passes a pointer to a single one of those > > instead. > > > > Because it's more convenient, it also puts the section_vaddresses > > calculations in locate_section(), which no longer returns the allocation > > for section_addresses directly either. > > > > This shouldn't change the binary file output or the "grub-mkimage -v" > > output in any way. ...
> > > > #ifdef MKIMAGE_ELF32 > > -/* Deal with relocation information. This function relocates addresses > > +/* Deal with relocation information. This function relocates addrs > > I think that this and comments below are changed by mistake. > If it is true I can fix it during commit. You're right, and also I should have removed the middle paragraph of the commit message, because that part is done in a prior patch now. Thanks for the careful read through. -- Peter _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
