Hi Leif, Sorry for late reply but I am traveling. I should be more responsive starting from next week.
On Tue, Sep 05, 2017 at 09:41:11PM +0100, Leif Lindholm wrote: > Rename GRUB_LINUX_MAGIC_SIGNATURE -> GRUB_LINUX_I386_MAGIC_SIGNATURE > and linux_kernel_header -> linux_i386_kernel_header. I think that this begs for 2 separate patches. > Also change the include guard on grub/i386/linux.h to prevent clashes > when including multiple linux.h headers (like in commands/file.c). Third patch. > Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > > OK, so one question here: in order to follow existing style, I have kept > to the existing linux_ format. Is that the appropriate prefix, or should > this be grub_linux_ like I originally used in the ARM series? I prefer linux_. > Regardless, I intend to align the ARM patches to whatever format ends up > being used for this patch. Please do. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel