If it solves the problem, go ahead

Le ven. 18 mars 2016 17:53, Andrei Borzenkov <arvidj...@gmail.com> a écrit :

> 18.03.2016 16:01, Jiri B пишет:
> > On Fri, Mar 18, 2016 at 06:26:47AM +0300, Andrei Borzenkov wrote:
> >>> [...]
> >>>   CFLAGS=-ftrampolines -fno-stack-protector -fno-pie -nopie
> >>>
> >>> So I gave it a try and it seems better (?)
> >>>
> >>> $ ls -l
> /home/jirib/openbsd/pobj/grub-2.02-beta3/fake-amd64/usr/local/lib/grub/i386-pc/
> lzma_decompress.im*
> >>> -rwxr-xr-x  1 jirib  wheel  3068 Mar 17 21:45
> /home/jirib/openbsd/pobj/grub-2.02-beta3/fake-amd64/usr/local/lib/grub/i386-pc/lzma_decompress.image*
> >>> -rw-r--r--  1 jirib  wheel  2832 Mar 17 21:45
> /home/jirib/openbsd/pobj/grub-2.02-beta3/fake-amd64/usr/local/lib/grub/i386-pc/lzma_decompress.img
> >>>
> >>> $ objdump -f
> /home/jirib/openbsd/pobj/grub-2.02-beta3/fake-amd64/usr/local/lib/grub/i386-pc/lzma_decompress.image
> >>>
> >>>
> /home/jirib/openbsd/pobj/grub-2.02-beta3/fake-amd64/usr/local/lib/grub/i386-pc/lzma_decompress.image:
>    file format elf32-i386
> >>> architecture: i386, flags 0x00000002:
> >>> EXEC_P
> >>> start address 0x00008200
> >>>
> >>> It is OK?
> >>>
> >>
> >> It certainly looks better than before. Does it actually work?
> >>
> >> We aready use -fno-PIE, looks like we need to explicitly check for
> >> -fno-pie as well.
> >
> > I just booted OpenBSD from "native OpenBSD" grub2:
> >
>
> Good. Please test attached patch.
>
> @Vladimir: I was unsure whether to add explicit -fpie test, but at the
> end I do not see what it buys us. Both options have been introduced at
> the same time and we want neither enabled. Current test covers both.
>
> Is it OK to commit?
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to