On Mon, Aug 17, 2015 at 09:51:58AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, <daniel.ki...@oracle.com> wrote: > > Create generic alloc and copy functions. We need > > separate tools for memory allocation and copy to > > provide multiboot2 protocol support. > > > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > --- > > v2 - suggestions/fixes: > > - generalize new functions names > > (suggested by Jan Beulich), > > - reduce number of casts > > (suggested by Jan Beulich). > > This contradicts retaining Andrew's R-b tag. Please remember to > drop tags for everything you make non-trivial changes to.
OK. > > @@ -55,50 +56,64 @@ static void *reloc_mbi_struct(void *old, unsigned int > > bytes) > > " sub %1,%0 \n" > > " and $~15,%0 \n" > > " mov %0,alloc-1b(%%edx) \n" > > - " mov %0,%%edi \n" > > - " rep movsb \n" > > - : "=&r" (new), "+c" (bytes), "+S" (old) > > - : : "edx", "edi", "memory"); > > - return new; > > + : "=&r" (s) : "r" (bytes) : "edx", "memory"); > > Can't "bytes" use a simple "g" constraint now? Works... > Preferably (i.e. if correct) this changed ..., so, I will change that. > Acked-by: Jan Beulich <jbeul...@suse.com> Thanks! Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
