> On 03.05.2015, at 22:23, Andrei Borzenkov <arvidj...@gmail.com> wrote: > >>> >> >> they do implement read support extensible dataset… instead of fixed DMU >> types they dont specify type, making it possible to use fat zap objects from >> bonus area. >> >> reference commit: >> https://github.com/illumos/illumos-gate/commit/2acef22db7808606888f8f92715629ff3ba555b9 >> > > OK; just to be sure - there are several remaining uses of > DMU_OT_DSL_DATASET and DMU_OT_DSL_DIR; are these intentional?
they *should* be ok. at least browsing and loading files from datasets haven’t revealed other instances over the test time. but problem is, the cases of zapify (when “normal” structure is wrapped as zap object) I have seen, have been related to datasets using >128k recordsize, and its possible some cases may have been missed - the grub zfs code and real zfs code are not exactly easy to compare. at least so far I haven’t seen bugs related to this nor received any reports. the basic symptom can be either message about wrong type or “missing” directory entry in listing. rgds, toomas > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
