On Mon, Jan 26, 2015 at 6:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko <phco...@gmail.com> wrote: > On 26.01.2015 12:29, Andrei Borzenkov wrote: >>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64" >>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64" >> >> >> We already have them unconditionally in config.h. This is confusing; >> may be remove them from this file. OTOH we have AC_LARGEFILES that is >> expected to figure out proper options (although I believe for now >> there is just one system that needs it). >> > Do you mean AC_SYS_LARGEFILE ? Does it actually work?
It apparently works for other projects ... > > How exactly does > it make its way to HOST_CPPFLAGS? It does not, that is my point. We uncoditionally force both known knobs statically in config.h. I'm fine with forcing it in configure (then at least check for sizeof(off_t) will match what we have at compilation time) but then they must be removed from config.h. But yes, for now AC_SYS_LARGEFILE is pretty much useless here. >> >> This all looks rather messy. >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
