On Fri, Jan 23, 2015 at 12:45 PM, Vladimir 'φ-coder/phcoder'
Serbinenko <phco...@gmail.com> wrote:
> On 23.01.2015 10:40, Andrei Borzenkov wrote:
>> On Fri, Jan 23, 2015 at 1:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko
>> <phco...@gmail.com> wrote:
>>> On 22.01.2015 22:25, Kris Moore wrote:
>>>>
>>>> Hey all,
>>>>
>>>> We are trying to create hybrid USB/DVD images, and they work just fine
>>>> on BIOS. However it doesn't seem to work when creating UEFI.
>>>>
>>> Try this:
>>> diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
>>> index 3b12c34..983afdb 100644
>>> --- a/grub-core/disk/efi/efidisk.c
>>> +++ b/grub-core/disk/efi/efidisk.c
>>> @@ -862,9 +862,7 @@ grub_efidisk_get_device_name (grub_efi_handle_t *handle)
>>> if (! ctx.partition_name)
>>> {
>>> grub_disk_close (parent);
>>> - if (is_cdrom)
>>> - return grub_strdup (device_name);
>>> - return 0;
>>> + return grub_strdup (device_name);
>>
>> How is it possible? So we have EFI device path that refers to
>> partition (or at least to something that does not start on device
>> first block) but grub does not see this partition? In case of CD-ROM
>> this happens because CD-ROM media subtype actually refers to ESP and
>> so points inside CD-ROM. But how it can happen for hard disk?
>>
> I think his EFI uses eltorito even from the stick. In that case we end
> up in exactly the same scenario as CD-ROM.
That's fine but then I expect CD-ROM subtype. I'd love to see full device path.
>> Kris, could you add output of device path (grub_efi_print_device_path)
>> at the beginning?
>>
>>
>>> }
>>>
>>> dev_name = grub_xasprintf ("%s,%s", parent->name,
>>>
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
