Yes. My patch looked exactly like that. Minus the comment changes. ;)
I can not see any harm from this while running. Maybe this needs to be tested 
more?
Linux looks like it has it as default.
linux-3.10/drivers/usb/host/pci-quirks.c. Looks like it hands over from BIOS 
and disable the ehci-controller in preparation for the EHCI driver.

Regards,
Christian

> -----Original Message-----
> From: grub-devel-bounces+christian.melki=saabgroup....@gnu.org
> [mailto:grub-devel-bounces+christian.melki=saabgroup....@gnu.org] On
> Behalf Of Aleš Nesrsta
> Sent: den 31 augusti 2013 23:13
> To: The development of GNU GRUB
> Subject: [PATCH] Re: Missing USB devices.
> 
> Hmmm, today is not a good day - I sent wrong patch with mistake, sorry... :-(
> 
> I hope attached patch is finally OK...
> 
> BR,
> Ales
> 
> > Sorry, I missed the patch... :-)
> > There it is.
> >
> >> 28.8.2013 08:59, Melki Christian (consultant) wrote:
> >>> I'm thinking of the EHCI hand-over. In the case of EHCI handover
> >>> beeing successful within the timeout, you never clear the
> >>> USBLEGCTLSTS register (SMI's). You do that in the other cases
> >>> however. Why? I can not think of any case of a successful handover
> >>> with SMI's still enabled. To what purpose? A buggy BIOS would maybe
> >>> act upon such stuff? Maybe thats a case for lost devices etc?
> >> Ok, I made a short look into Linux USB source code and I saw there is
> >> USBLEGCTLSTS register reset in any case.
> >> (What is maybe more interesting, Linux driver DOES NOT handover on
> >> some
> >> (broken) devices, only reset SMI...)
> >>
> >> So I prepared simple "SMI" patch (attached).
> >>
> >> BR,
> >> Ales
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> >

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to