On 06.08.2013 10:35, Pawel Wojtalczyk wrote:
+#if defined (__i386__) || defined (__x86_64__)
+ if (key.unicode_char < 0x20 && key.unicode_char != 0 &&
key.unicode_char != '\t' && key.unicode_char != '\b' && key.unicode_char
!= '\n' && key.unicode_char != '\r')
+ return GRUB_TERM_CTRL | (key.unicode_char - 1 + 'a');
+ else
+#endif /* defined (__i386__) || defined (__x86_64__) */
+ return key.unicode_char;
else if (key.scan_code < ARRAY_SIZE (efi_codes))
This results in an ambigous else which should be avoided. Also I see no
reason to restrict this to x86 as other platforms are likely to have the
same bug. Also it requires a comment as to why this workaround is
necessarry. Please supply a ChangeLog entry.
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
