> -----Original Message----- > From: grub-devel-bounces+stuart_hayes=dell....@gnu.org [mailto:grub- > devel-bounces+stuart_hayes=dell....@gnu.org] On Behalf Of Vladimir 'f- > coder/phcoder' Serbinenko > Sent: Wednesday, June 27, 2012 3:51 PM > To: Hayes, Stuart > Cc: bug-g...@gnu.org; grub-devel@gnu.org; Dominguez, Jared > Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some > systems > > On 27.06.2012 21:59, stuart_ha...@dell.com wrote: > > >> > >> Well, this works, too (on top of HEAD from 7 june). > >> > >> > >> --- ../../grub/grub-core/loader/i386/linux.c 2012-05-31 > >> 12:59:19.000000000 -0400 > >> +++ grub-core/loader/i386/linux.c 2012-06-12 20:47:51.455718055 > -0400 > >> @@ -139,7 +139,7 @@ find_efi_mmap_size (void) > >> > >> /* Increase the size a bit for safety, because GRUB allocates > more > >> on > >> later, and EFI itself may allocate more. */ > >> - mmap_size += (1 << 12); > >> + mmap_size += (3 << 12); > >> > >> mmap_size = page_align (mmap_size); > >> return mmap_size; > > > > Vladimir, > > > > The 2.00rc1 version of grub2 still doesn't fix the efi memory map > buffer size I've been working on (though I can see you are now > allocating the efi memory map buffer very shortly before you are > calling grub_efi_finish_boot_services()). > > > > Increasing the mmap_size in find_efi_mmap_size()--as in the patch > immediately above this text--does fix the problem. Even adding (2 << > 12) (instead of (1 << 12)) to the mmap_size will work on the system I'm > testing with. > > > > I've changed it to 3. Thanks. It's annoying that even such simple > operations as we have between find_efi_mmap and finish drastically > increase memory map size. > > -- > Regards > Vladimir 'φ-coder/phcoder' Serbinenko
Thanks! I completely agree that it is annoying. _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
