Re: [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer

[Aleš Nesrsta]

Vladimir 'φ-coder/phcoder' Serbinenko wrote: 
> On 09/23/2010 10:27 PM, Aleš Nesrsta wrote:
> >       code works on on 64 bits architectures.  */
> > -  u->td = (grub_uhci_td_t) grub_memalign (4096, 4096*2);
> > +  u->td = (grub_uhci_td_t) grub_memalign (4096, 32*N_TD);
> >    if (! u->td)
> >      goto fail;
> >   
> Could you use sizeof while on it?
> 
> -      endpdesc = grub_usb_get_endpdescriptor (dev, 0);
> +      endpdesc = grub_usb_get_endpdescriptor (dev, endpoint);
> It's hard to see the context of this change. Could you use --diff-options=-p 
> in the future?
> Other than that this patch is ok for trunk

Hi,
there is corrected patch (with sizeof and -p) for review before going to
trunk.
Regards
Ales


diff -purB ./grub/grub-core/bus/usb/ohci.c ./grub_patched/grub-core/bus/usb/ohci.c
--- ./grub/grub-core/bus/usb/ohci.c	2010-09-30 22:17:31.000000000 +0200
+++ ./grub_patched/grub-core/bus/usb/ohci.c	2010-10-01 11:24:29.000000000 +0200
@@ -150,7 +150,7 @@ typedef enum
 #define GRUB_OHCI_RESET_CONNECT_CHANGE (1 << 16)
 #define GRUB_OHCI_CTRL_EDS 256
 #define GRUB_OHCI_BULK_EDS 510
-#define GRUB_OHCI_TDS 256
+#define GRUB_OHCI_TDS 640
 
 #define GRUB_OHCI_ED_ADDR_MASK 0x7ff
 
diff -purB ./grub/grub-core/bus/usb/uhci.c ./grub_patched/grub-core/bus/usb/uhci.c
--- ./grub/grub-core/bus/usb/uhci.c	2010-09-30 22:17:31.000000000 +0200
+++ ./grub_patched/grub-core/bus/usb/uhci.c	2010-10-01 11:31:44.000000000 +0200
@@ -29,6 +29,7 @@
 #define GRUB_UHCI_IOMASK	(0x7FF << 5)
 
 #define N_QH  256
+#define N_TD  640
 
 typedef enum
   {
@@ -105,7 +106,7 @@ struct grub_uhci
   /* N_QH Queue Heads.  */
   grub_uhci_qh_t qh;
 
-  /* 256 Transfer Descriptors.  */
+  /* N_TD Transfer Descriptors.  */
   grub_uhci_td_t td;
 
   /* Free Transfer Descriptors.  */
@@ -213,7 +214,7 @@ grub_uhci_pci_iter (grub_pci_device_t de
 
   /* The QH pointer of UHCI is only 32 bits, make sure this
      code works on on 64 bits architectures.  */
-  u->qh = (grub_uhci_qh_t) grub_memalign (4096, 4096);
+  u->qh = (grub_uhci_qh_t) grub_memalign (4096, sizeof(struct grub_uhci_qh)*N_QH);
   if (! u->qh)
     goto fail;
 
@@ -227,7 +228,7 @@ grub_uhci_pci_iter (grub_pci_device_t de
 
   /* The TD pointer of UHCI is only 32 bits, make sure this
      code works on on 64 bits architectures.  */
-  u->td = (grub_uhci_td_t) grub_memalign (4096, 4096*2);
+  u->td = (grub_uhci_td_t) grub_memalign (4096, sizeof(struct grub_uhci_td)*N_TD);
   if (! u->td)
     goto fail;
 
@@ -244,9 +245,9 @@ grub_uhci_pci_iter (grub_pci_device_t de
 
   /* Link all Transfer Descriptors in a list of available Transfer
      Descriptors.  */
-  for (i = 0; i < 256; i++)
+  for (i = 0; i < N_TD; i++)
     u->td[i].linkptr = (grub_uint32_t) (grub_addr_t) &u->td[i + 1];
-  u->td[255 - 1].linkptr = 0;
+  u->td[N_TD - 2].linkptr = 0;
   u->tdfree = u->td;
 
   /* Make sure UHCI is disabled!  */
diff -purB ./grub/grub-core/bus/usb/usbtrans.c ./grub_patched/grub-core/bus/usb/usbtrans.c
--- ./grub/grub-core/bus/usb/usbtrans.c	2010-09-30 22:17:31.000000000 +0200
+++ ./grub_patched/grub-core/bus/usb/usbtrans.c	2010-10-01 11:24:29.000000000 +0200
@@ -228,7 +228,7 @@ grub_usb_bulk_setup_readwrite (grub_usb_
   if (dev->initialized)
     {
       struct grub_usb_desc_endp *endpdesc;
-      endpdesc = grub_usb_get_endpdescriptor (dev, 0);
+      endpdesc = grub_usb_get_endpdescriptor (dev, endpoint);
 
       if (endpdesc)
 	max = endpdesc->maxpacket;

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel