Hi,

today i downloaded by:
  bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub

Building it on a Debian 5.04 GNU/Linux with gcc 4.3.2 failed:
  $ make
  ...
  cc1: warnings being treated as errors
  disk/mdraid1x_linux.c: In function 'grub_mdraid_detect':
  disk/mdraid1x_linux.c:108: error: 'sector' may be used uninitialized in this 
function
  ... consequential error messages and abort of the make rum ...

In grub-core/disk/mdraid1x_linux.c i see

    grub_disk_addr_t sector;
    ...
    for (minor_version = 0; minor_version < 3; ++minor_version)
      {
        switch (minor_version)
        {
        case 0:
          sector = (size - 8 * 2) & ~(4 * 2 - 1);
          break;
        case 1:
          sector = 0;
          break;
        case 2:
          sector = 4 * 2;
          break;
        }

      if (grub_disk_read (disk, sector, 0, sizeof (struct grub_raid_super_1x),
                          &sb))
      ...

It helps to change "case 2:" to "default:". So this is indeed the spot
which itches.

There are other warnings to see with other source files which do not lead
to abort of make. If there is interest i can post them.


Have a nice day :)

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to