On 09/01/2010 02:40 PM, Yves Blusseau wrote:
> * Makefile.am: Add util/bash-completion.d directory
> * configure.ac: Likewise.
> * util/bash-completion.d/Makefile.am: New file.
> * util/bash-completion.d/grub-completion.bash.in: Likewise.
> ---
> ChangeLog.completion.bash | 6
> Makefile.am | 2
> configure.ac | 1
> util/bash-completion.d/Makefile.am | 15 +
> util/bash-completion.d/grub-completion.bash.in | 450
> ++++++++++++++++++++++++
> 5 files changed, 473 insertions(+), 1 deletions(-)
> create mode 100644 ChangeLog.completion.bash
> create mode 100644 util/bash-completion.d/Makefile.am
> create mode 100644 util/bash-completion.d/grub-completion.bash.in
>
> bash-completion.patch
>
>
> +DISTCLEANFILES = *~
>
We don't add *~ in other Makefile.am. If this should be changed it
should be on the level of whole GRUB
> +...@grubname@_dir() {
>
Functionnames aren't transformed
> + root_dir=${root_dir-/}
>
but dirnames are
> + if [[ -d "$root_dir/boot" ]]; then
> + boot_dir="$root_dir/boot"
>
likewise
> + else
> + boot_dir="$root_dir"
>
> + fi
> + echo "${boot_dir%/}/grub"
>
likewise
These errors repeat themselves many times and make the patch more
difficult to read. Once they are fixed I'll have another look for more
comments.-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
