George Buranov wrote:
> Hello eveybody.
>
> I am currently start investigation (and fixing the things that don't
> work for me =))
>
> So, I got two for today, one is fix, and one is morelike a question, I
> am more than sure it's my mistake.
>
> What's the correct way of applying patches to grub2? Am I correct that
> all I need is to post the patch to this mailing list and than some
> guys are applying them?:)
>
> 1) IMHO that's clearly a bug.
It is. Can you write a ChangeLog entry?
> Actually, I am not sure how did it work before =)
It's a rarely used branch of code.
>
> === modified file 'disk/efi/efidisk.c'
> --- disk/efi/efidisk.c 2010-01-20 08:12:47 +0000
> +++ disk/efi/efidisk.c 2010-02-11 10:58:49 +0000
> @@ -825,7 +825,7 @@
> if (! disk)
> return 1;
>
> - if (disk->id == GRUB_DISK_DEVICE_EFIDISK_ID)
> + if (disk->dev && disk->dev->id == GRUB_DISK_DEVICE_EFIDISK_ID)
> {
> struct grub_efidisk_data *d;
>> 2) That's more interesting. I nocticed that when I try to browse CD > (ISO 9660 format) all files are ended with ";1". This basically > crashed loading everything (including grub.cfg file). I fixed this by > this stupid hack, but maybe somebody knows where is the clue? > ;1 is so called version. Basically all terminating ;<number> have to be stripped but only if filename doesn't come from rockridge or joliet. Apparently nobody uses grub2 on non-rockridge, non-joliet iso. While this bug should be fixed using grub from plain iso isn't supported due to filename length limitation. > http://picasaweb.google.com/lh/photo/psaYCXsX_M77pdG4_qeFGw?feat=directlink > > === modified file 'fs/iso9660.c' > --- fs/iso9660.c 2010-01-27 03:11:20 +0000 > +++ fs/iso9660.c 2010-02-11 11:11:36 +0000 > @@ -638,6 +638,9 @@ > if (filename_alloc) > grub_free (oldname); > > + int hookedFile = grub_strlen (filename); > + filename[hookedFile - 2] = '\0'; > + > filename_alloc = 1; > } > > > Regards, > Georgy > ------------------------------------------------------------------------ > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
