I haven't checked the specific details, but I think this approach is fine IF
we only recurse for partition types where this makes sense. This includes:
- BSD partition types inside MSDOS labels
- Solaris partition type inside MSDOS labels
This can be done by extending "has_partitions" to be set to "yes" in those
specific partition types. The implementation should be the least intrusive
possible, taking into account that this kind of situations are an oddity
rather than the norm.
As for the other situations, the more I think about this, the more convinced
I am that this whole "partition nesting" concept is a broken mess. I think I
already explained why in this list, but I can rehash the reasons if anyone's
interested. I don't want to compromise on such part of GRUB core for the sake
of supporting this kind of layouts.
The only reason I'm open to implementing these two cases [1] is that they seem
to be inmensely popular among *BSD systems and Solaris derivatives.
As for *BSD and Solaris who read this, my advice is to step away, ditch the
whole MSDOS label burden and just settle on a clean label without the limits
DOS ones have. If you strive for compatibility, GPT is a good choice IMO (and
the rest of the free world seems to be moving in this direction thanks to 2 TiB
limit).
[1] I know the first one is already implemented, but your approach makes it
less ad-hoc and splits code off part_msdos.mod, which is an improvement.
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
