On Sun, Jan 17, 2010 at 01:02:55PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Fri, Jan 01, 2010 at 09:32:24AM +0000, Colin Watson wrote: > > > >> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' > >> Serbinenko wrote: > >> > >>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > >>> + __attribute__ ((format (printf, 1, 2))); > >>> > >> It's very confusing that you've made grub_asprintf have a dramatically > >> different interface from asprintf. Perhaps you could call this > >> grub_xasprintf instead? > >> > > > > Is it feasible to implement the same interface as asprintf instead? > > > > > it's feasible but the only advantage it gives is the return value nobody > uses anyway
What about consistency with what programmers expect? If you don't want the return value, you can just discard it. -- Robert Millan "Be the change you want to see in the world" -- Gandhi _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
