Robert Millan wrote: > Hi, > > I've removed loader/efi/appleloader.c, because it contained blobs of > binary data. If someone can provide a satisfactory explanation for > them, it can be added back. However, this command seems to be seldom > needed. > > Please keep in mind binary blobs or other kind of obfuscated data is not > acceptable in GRUB. If it's machine code, we need its source code. If > it's a magic signature, we need a comment and/or macro explaining that, > etc. > > They are device identifiers in EFI format. E.g. This static grub_uint8_t devpath_5[] = { 0x01, 0x03, 0x18, 0x00, 0x0B, 0x00, 0x00, 0x00, 0x00, 0x40, 0xCB, 0xFF, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xBF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00, 0x04, 0x06, 0x14, 0x00, 0xEB, 0x85, 0x05, 0x2B, 0xB8, 0xD8, 0xA9, 0x49, 0x8B, 0x8C, 0xE2, 0x1B, 0x01, 0xAE, 0xF2, 0xB7, 0x7F, 0xFF, 0x04, 0x00, };
Means MMIO(EfiMemoryMappedIO, 0xffcb4000-0xffffbfff)/PIWGVolume(2B0585EB-D8B8-49A9-8B8CE21B01AEF2B7) I can add necessary prototypes and structures -- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel