Felix Zielcke wrote: > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but > everywhere else as `grub_halt (void)' > util/grub-emu.c has a #ifdef for these 2 > > Shouldn't we just add an int parameter everywhere to make this more > simple? > > I think in future we'll have more different halt methods on different platforms. So we could do: grub_halt (int methods) And have e.g. GRUB_HALT_DEFAULT_METHODS And e.g. on i386: #define GRUB_HALT_DEFAULT_METHODS (GRUB_HALT_APM|GRUB_HALT_ACPI|GRUB_HALT_HANG) > grub-emu fails to build on powerpc now because grub/cpu/halt.h doestn't > exist there: > https://buildd.debian.org/fetch.cgi?pkg=grub2;ver=1.97%2B20091125-1;arch=powerpc;stamp=1259179180 >
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
