>Index: include/grub/i386/cpuid.h >=================================================================== >--- include/grub/i386/cpuid.h (revision 0) >+++ include/grub/i386/cpuid.h (revision 0)
This file doesn't follow convention of having an ifdef around the file >+extern unsigned char grub_cpuid_has_longmode; I don't like it being declared as a variable: user may inadvertently assign a value to it. I would be more confortable with a function Other than that patch looks good -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
