On Mon, Aug 24, 2009 at 09:23:22PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> 2009-08-24 Vladimir Serbinenko <phco...@gmail.com> > > UTF-8 to UTF-16 transformation. > > * conf/common.rmk (pkglib_MODULES): Add utf.mod > (utf_mod_SOURCES): New variable. > (utf_mod_CFLAGS): Likewise. > (utf_mod_LDFLAGS): Likewise. > * include/grub/utf.h: New file. > * lib/utf.c: New file. (Based on grub_utf8_to_ucs4 from kern/misc.c) Sounds like we could end up needing more of this (to other charsets), so why not give this module a generic name to hint as to where it can be added? The conversion functions in kern/misc.c could eventually move there as well, once UTF-8 support becomes optional in the kernel. GNU libc has "iconv" command and "iconv_*" facilities for charset conversion, how about iconv.mod for consistency? > + if ((c & 0x80) == 0x00) > + code = c; > + else if ((c & 0xe0) == 0xc0) These should be macroified. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel