On Sun, Aug 23, 2009 at 12:57 PM, Robert Millan<r...@aybabtu.com> wrote:
> On Sat, Aug 22, 2009 at 04:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> [...]
>> +
>> +pkglib_MODULES += utf.mod
>> +utf_mod_SOURCES = lib/utf.c
>> +utf_mod_CFLAGS = $(COMMON_CFLAGS)
>> +utf_mod_LDFLAGS = $(COMMON_LDFLAGS)
>> [...]
>> +#include <grub/utf.h>
>> +
>> +grub_ssize_t
>> +grub_utf8_to_utf16 (grub_uint16_t *dest, grub_size_t destsize,
>> + const grub_uint8_t *src, grub_size_t srcsize,
>> + const grub_uint8_t **srcend)
>> +{
>
> This was moved from another file, right? Please could you send it as a
> separate patch?
Nope, it's a new function. But I'm ok with splitting patches.
>
> Also, please remember to include a ChangeLog entry.
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
> how) you may access your data; but nobody's threatening your freedom: we
> still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
