2009/8/14 Michal Suchanek <hramr...@centrum.cz>: > 2009/8/13 Vladimir 'phcoder' Serbinenko <phco...@gmail.com>: >>> Considering that vbe.c and sdl.c currently aren't affected a lot >>> whether there is or there isn't encapsulation in place, I'm ok tih >>> encapsulating it but if any driver needs the breach of encapsulation >>> it will be broken and I'll post no opposition to it. >>> I'll do the encapsulation tomorrow. >> Patch attached. One incremental version (for review) and one complete
> > In grub_video_vbe_setup function in vbe.c the default palette is > loaded before the created render target is set as active. I guess this > would be a problem if the palette was actually needed/supported. > Changing the order to create, set_active, set_palette makes the code > fail for me,though. > > In this same code struct grub_video_mode_info mode_info is added in > the last round of patches but I cannot find where the changed code > touches the variable. This is somewhat odd. Looking at grub_video_vbe_setup I think this could get some more decrufting but this is outside of the scope of framebuffer split and can be looked at once the split is in. Thanks Michal _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
