On Sun, Aug 9, 2009 at 1:55 PM, Michal Suchanek<hramr...@centrum.cz> wrote: > Hello, > > both in the previous complete patch and Vladimir's git repository > introduce a grub_video_rect_t type. This is from Collin's double buffering patch. > The other thing that bothers me is that the video drivers fill in the > render target structure during video initialization. > > In my view the render target structure should not be public. It isn't. If you read the code you'll see that video_render_target is anonymous structure except in drivers. > The video > driver should fill in the video mode structure and then call a > function that fills in render target based on video mode and video > data (framebuffer memory). This code is currently replicated > needlessly in the vbe and sdl drivers. I split on the most natural spot I found - render targets. Everything that works with render targets is moved to video_fb. Perhaps it's not the best spot but cutting at natural function ensures drivers won't have to undo something video_fb does. In future if drivers share code which can be moved to vide_fb then I'm ok with it but I prefer to see more real drivers first before fine-tuning split limit especially away fro ma natural spot As for moving data from video info to render target the problem is that video_fb can't be aware about the structures used by drivers. and so I see no way around it > > Bitmaps could be created in the same way. > > Thanks > > Michal > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
