On Mon, Aug 3, 2009 at 12:25 AM, Robert Millan<r...@aybabtu.com> wrote: > On Mon, Aug 03, 2009 at 12:09:32AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> >> + grub_device_close (dev); >> > >> > I don't think we should allow chainload at all in partitions other than >> > msdos >> > ones. There's no existing use of this for other labels "in the wild", and >> > we >> > shouldn't encourage it to appear IMO. >> Actually it's something which happens with GPT. Suppose you have an OS >> on your GPT which has no multiboot support. In this case you use >> gptsync to create a fake msdos partition map and boot your OS. > > So gpt could be the other exception because it is backward compatible with > msdos labels (to some extent). > > But please let's not make a general rule out of this. The chainloader is > an implementation of the DOS MBR<->PBR boot protocol, which has been mimicked > by others but is still only available on msdos labels. If someone tries it > on another partition label type, she should see an error. > > Btw, does this bugfix depend on the rest of nested partition changes? > Actually only superficially > + disk->partition = p->parent; this line would be = 0; without nestpart patch. If you want I can commit it separately.
The following line is bogus: > + /* In i386-pc, the id is equal to the BIOS drive number. */ > + drive = (int) disk->id; It shouldn't have been here at all - it was written before introduction of biosnum. I won't resend the patch because of this but I corrected it in my local git > -- > Robert Millan > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > how) you may access your data; but nobody's threatening your freedom: we > still allow you to remove your data and not access it at all." > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
