On Tue, Jul 28, 2009 at 10:58:55PM -0700, Joe Auricchio wrote:
>
> On 25 Jul, 2009, at 09:21 , Robert Millan wrote:
>> On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
>>>
>>>
>>> How's this?
>>
>> The ChangeLog entry is incomplete.  It should be e.g.:
>>
>>      * commands/minicmd.c (grub_mini_cmd_clear): New function.
>>
>> etc.  See other entries as an example.
>
> Updated patch attached.

Hi,

The ChangeLog entry is incomplete, it should list the changes in
GRUB_MOD_INIT(minicmd) and GRUB_MOD_FINI(minicmd) too.

Btw, your mailer sends text attachments with Content-Type set to
application/octet-stream.  Please could you adjust it so that it
sets it to the standard text/plain MIME type?  Otherwise mail clients
may fail to recognize it as text, which makes context reply difficult.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to