>> *_mask normally shouldn't be used in index color by internal grub >> functions anyway. And if payload needs a special convention for >> passing color info for indexed modes it should be handled by loader > > Ok. But if we decide that *_mask should go away, this is quite independant > from this patch. For RGB modes masks are needed anyway. Idk why linux needs DAC width but it may potentially need something analogous to *_mask_offset for indexed modes too. >> It's ok but once we get my mm functions in and move this part to >> vbe.mod splitting get and set will be a good idea > > Actually, my disjunctive was between providing getset or only set. I don't > see the point of two separate functions. Separate functions seem to be a bit clearer but it's not that important >> + /* 6 is default after mode reset. */ >> + width = 6; >> Looks like a hack and some boards may have different value. Is there a >> better way? > > It is 6 according to the VBE spec (Linux is also consistent with that). > Then ok > -- > Robert Millan > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > how) you may access your data; but nobody's threatening your freedom: we > still allow you to remove your data and not access it at all." > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
