On Thu, 2009-07-23 at 13:10 +0200, Javier Martín wrote: > Currently <grub/types.h> verifies that sizeof(void*)==sizeof(long) and > then proceeds to define most fixed-length types based on sizeof(void*). > While simplification seems a good idea on paper, it is always good > practice to check specifically for what we want to know. In particular, > the assumption that long can hold a pointer will go down when (if) > mingw64 support is merged, because Win64 follows the LLP64 model instead > of the LP64 *nix model. > > Given that currently both values are, by precondition, the same, this > change is guaranteed not to create any problems, while it might avoid > them in the future.
The patch is good. Please include the ChangeLog entry. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
