On Tue, Jul 21, 2009 at 11:45:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > This change would allow to produce a code which is cleaner, easier to > read and understand. However I'm opposed to modifying printf function > for it. Instead we could just define somewhere: > GRUB_PRIx32 "%x" > #ifdef LONG_SIZEOF == 8 > GRUB_PRIx64 "%lx" > #else > GRUB_PRIx64 "%llx" > #endif
This is unnecessary. We defined the data as grub_uint32_t, so just dropping the 'l' and the `unsigned long' casts should do. As Pavel said, if we ever support a platform where sizeof(int) != 4, we have more serious problems to worry about. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
