On Fri, 2009-06-19 at 13:53 +0200, Vladimir 'phcoder' Serbinenko wrote: > Attached to this e-mail and on my personal git repository in branch > bless the rediff. I was thinking of adding ppc mac support but haven't > done it yet I think we can incorporate apple intel support without the > ppc counterpart yet. Does anyone object?
I don't see how PowerPC support would be different. It's a filesystem issue. Actually, on PowerPC blessing on HFS (not on HFS+) would be needed. I think it would be better to name the command "hfsbless". The way, HFS support could be added to the same command later. Adding commands/hfspbless.c to grub_emu_SOURCES only on i386-pc seems inconsistent. Either it should be added everywhere or nowhere. I think we need a build system reorganization to allow grub_emu_SOURCES to be mostly platform independent. The spacing change in conf/i386-pc.rmk is unnecessary. "(void) mod;" is unnecessary. fs/hfsplus.c should include grub/hfsplus.h or it won't compile. In find_inode(), the core start with if(! info->inodeset) return 0; It's both faster and more readable. Please run hfspbless.c through indent. It would fix such things as (fs->dir) (dev, *path == 0 ?"/":path, find_inode); -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
