On Tue, Jun 16, 2009 at 3:32 AM, Pavel Roskin <pro...@gnu.org> wrote:

> On Sat, 2009-05-30 at 16:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> > +#ifdef APPLE_CC
> >    __asm__ __volatile__ ("xorl %%eax, %%eax\n\t"
> > -                        "cpuid":::"%rax", "%rbx", "%rcx", "%rdx");
>
> Why do we need preprocessor conditionals here?  What are we winning?  I
> think it's more important to have reusable, well tested and well
> maintained code that to save two assembly instructions.
>
You're right. Just when doing this thing I was concerned to affect generic
code as less as possible

>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to