On Sun, May 3, 2009 at 6:55 PM, Pavel Roskin <pro...@gnu.org> wrote: > On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: > > This is a patch to support UUIDs on HFS+. MD5 code is copied from > > Michael Gorven's patch which is copied from libgcrypt nearly verbatim. > > Thanks for Cris for the info about how xnu expects UUID to be > > I suggest that you run all new code through GNU indent. Spacing in > "32-(n)" will probably need to be fixed manually, as it's a preprocessor > directive. > > Commented out call to to _gcry_burn_stack() should probably be removed. > I would prefer that we don't use #undef. Instead, the preprocessor > defines should use unique names that never need to be redefined. > This part is temporary copied here till Michael Gorven's patch is merged.
> > Setting two environment variables is undocumented. I think rd_string > should not be needed. If you need it due to the script engine problems, > it's better to fix the script engine. I'm looking how to do it. The corresponding part to support foo=$bar is here but commented out. > At least please mark that hack as > a hack. > > Perhaps we should consider adding %X support to grub_printf(). I > realize that it will increase the core slightly, but if it's just a few > bytes, we could accept it. Other modules may use it. Let me think a bit about it. Unfortunately what seems to be few bytes in a first glance may be up to 100 bytes once implemented > Or maybe we could > have grub_toupper(), perhaps an inline function? > If it's an inline then it's ok. > > Another thing to consider is whether md5 support should be in a separate > file. It would make it possible to reuse md5 for other commands. > Actually md5 is a part of Michael Gorven patch where it's exported nicely but since his patch is pending I temporary copied it to this file. So I think it's unnecessary to > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
