Robert Millan wrote:
On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote:
Index: conf/i386-ieee1275.rmk
===================================================================
--- conf/i386-ieee1275.rmk (revision 2030)
+++ conf/i386-ieee1275.rmk (working copy)
@@ -126,10 +126,12 @@
# For _multiboot.mod.
_multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \
+ loader/i386/multiboot_helper.S \
multiboot_helper.S is not being used on i386-ieee1275 AFAICT
How can it be if multiboot.c is the same for pc and ieee1275?
- /* Unload all modules and stop the floppy driver. */
- call EXT_C(grub_dl_unload_all)
grub_dl_unload_all() just disappeared. Is this intentional? I
tend to agree that grub_dl_unload_all() is a waste of time, but
this should be discussed separately.
It is intentional because multiboot_real_boot is now in a module so we
can't unload it
- call EXT_C(grub_stop_floppy)
grub_stop_floppy() was moved to grub_multiboot_boot(). I think
grub_machine_fini() would be the more appropiate place. I'm not
sure why it was in those asm snippets to begin with (does someone
know?).
I'll have a look at it
Also, grub_unix_real_boot() completely disappeared with your patch.
This seems to break *BSD.
Last patch doesn't remove grub_unix_real_boot
--
Regards
Vladimir 'phcoder' Serbinenko
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
