On Sun, Mar 01, 2009 at 05:25:10PM +0100, phcoder wrote: > Hello all. It seems that gcc has trouble with -m32 when structure is > passed as argument. So I replaced that part by a pointer. Also I made > some improvements to ufs code to support solaris branch of ufs. I tested > it also with freebsd and netbsd's branch and it works fine on it too. > As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a > patch with all 3 features. If it's really necessary I can split them but > it requires a lot of unnecessary work
Please do. It is definitely confusing to review patches that merge unrelated things. Also, please don't include the changelog entry in your patch, since those break too easily. Just paste it at the top of your mail. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
