On Sat, 2008-12-27 at 04:08 +0800, jida...@jidanni.org wrote: > *** grub-installORIG.in 2008-12-27 02:43:09.000000000 +0800 > --- grub-install.in 2008-12-27 04:06:02.000000000 +0800 > *************** > *** 304,310 **** > # Prompt the user to check if the device map is correct. > ! echo "Installation finished. No error reported." > ! echo "This is the contents of the device map $device_map." > ! echo "Check if this is correct or not. If any of the lines is incorrect," > ! echo "fix it and re-run the script \`grub-install'." > ! echo > > --- 304,310 ---- > # Prompt the user to check if the device map is correct. > ! cat <<EOF > ! Installation finished. No error reported. These are the contents of > ! the device map $device_map. If any of the lines are incorrect, fix it > ! and/or re-run grub-install [--recheck]. > ! EOF
Actually, grub-install should not dump the whole device.map to the screen. It should only show the entries that it actually used during the installation. If no device.map entries were used (which is true in 99% cases, I guess), there should be no message at all. I'm not against mentioning "grub-install --recheck", although I'd like to see comment from the users of cross-device setups where device.map is actually used. They should know better if grub-install --recheck" does the right thing or grossly discards their manually crafted device.map files. If the later is true, maybe it's better to keep the current message. > -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
