Hi,
On Aug/24/2008, Vesa Jääskeläinen wrote:
> Carles Pina i Estany wrote:
> > I was just thinking... is there any reason that we have the same macros
> > in 4 different files?
> >
> > Why not having just a grub/console_scancodes.h:
> >
> > #ifndef GRUB_CONSOLE_SCAN_CODES
> >
> > #define GRUB_CONSOLE_KEY_LEFT 0x4B00
[...]
> > #define GRUB_CONSOLE_KEY_PPAGE 0x4900
> >
> > #endif
> >
> > and include this file from the other 4 files?
>
> Sounds fine. Why do we have same thing with TERM and CONSOLE?
Right now, these macros are in these files:
include/grub/powerpc/ieee1275/console.h
include/grub/sparc64/ieee1275/console.h
include/grub/i386/pc/console.h
include/grub/efi/console.h
In sparc64 there is a FIXME above the macros:
/* FIXME (sparc64). */
I would merge these macros in a file and include this file if all
architectures uses the same codes. But maybe next architecture (I mean,
right know it's powerpc, sparc64, i386 and efi) will use a different
codes.
What are your opinions, merging to a single file
(grub/console_scancodes.h?) or just leave in different files because one
of the files has a FIXME and maybe our next architecture will not share
these codes?
Sorry for so many questions. I guess that you have had the same question
in other areas in Grub.
--
Carles Pina i Estany GPG id: 0x17756391
http://pinux.info
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
