Am Montag, den 11.08.2008, 23:22 +0200 schrieb Robert Millan:
> 
> IIRC, the difference is that with the invalid BSD partitions, rising errors
> is ineffective as there can't be anyone to handle them (since we're inside
> an iteration).

Ah, yes that's a `little' difference between that and the RAID module.

> That'd be the upper layer.  E.g.

Right


> > +  grub_print_error();
> 
> Missing space here (before the parenthesis).

Yeah, right.
I'm still not that used to it. I never did that before on my own code,
but I think a space there isn't that bad :)

2008-08-11  Felix Zielcke  <[EMAIL PROTECTED]>

        * disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID 
        errors and reset grub_errno. Do not give errors to the upper layer.

Index: disk/raid.c
===================================================================
--- disk/raid.c	(Revision 1799)
+++ disk/raid.c	(Arbeitskopie)
@@ -581,6 +581,8 @@
 {
   grub_device_iterate (&grub_raid_scan_device);
   grub_disk_dev_register (&grub_raid_dev);
+  grub_print_error ();
+  grub_errno = GRUB_ERR_NONE;
 }
 
 GRUB_MOD_FINI(raid)
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to