Committed. On Fri, Jun 06, 2008 at 06:13:57PM +0200, Robert Millan wrote: > > Turns out that right now, if you try to boot from LVM on ext3 with msdos > partmap, you get a core.img that is slightly too big to fit in the post-MBR > region. When you're booting from LVM, if it won't fit there you have no > other option, which makes this a big problem. > > If you remove _chain from the list, it fits again. Since _chain can make the > difference between core.img fitting or not fitting, I think it should not be > included unless user requests it. > > -- > Robert Millan > > <GPLv2> I know my rights; I want my phone call! > <DRM> What good is a phone call… if you are unable to speak? > (as seen on /.)
> diff -x ChangeLog -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp > ../grub2/util/i386/pc/grub-install.in ./util/i386/pc/grub-install.in > --- ../grub2/util/i386/pc/grub-install.in 2008-06-06 17:49:43.000000000 > +0200 > +++ ./util/i386/pc/grub-install.in 2008-06-06 18:11:28.000000000 +0200 > @@ -231,8 +231,8 @@ partmap_module=`$grub_probe --target=par > # Device abstraction module, if any (lvm, raid). > devabstraction_module=`$grub_probe --target=abstraction --device > ${grub_device}` > > -# _chain is often useful > -modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module > _chain" > +# The order in this list is critical. Be careful when modifiing it. > +modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module" > > $grub_mkimage --output=${grubdir}/core.img > --prefix=`make_system_path_relative_to_its_root ${grubdir}`/ $modules || exit > 1 > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel