On Thu, Jun 12, 2008 at 2:22 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > Quoting Bean <[EMAIL PROTECTED]>: > >> This should be all right, but we need to move the journal support from >> fshelp.c to disk.c, anyone objects ? > > I've converted ext2.c. The patch is attached. The interface should be OK > for reiserfs. It looks like the call to grub_fshelp_map_block() from > grub_ext2_read_inode() was also wrong. I'm afraid there are some wrong > places in reiserfs as well.
The call in grub_ext2_read_inode should be ok, blkoff would limit the read access to within a block. > > I would like to commit the patch as soon as possible. It's a serious issue, > and we don't want to scare away potential testers and contributors. > > ChangeLog: > * fs/fshelp.c (grub_fshelp_read): New function. Implement linear > disk read with journal translation. > * fs/ext2.c: Use grub_fshelp_read() instead of grub_disk_read(). > * include/grub/fshelp.h: Declare grub_fshelp_read(). Seems fine to me. grub_ext3_get_journal still have some issue, but I can fix it after you commit it. -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
