On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote: > On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote: > > IMHO the name of this function is highly misleading. It makes one think > > it just checks something, but it actually modifies our variables. I think > > "adjust" would fit better than "check". > > But nothing can be better that a good old-fashioned connect before the > function. It looks like it does several things: > > 1) it makes sectors disk relative from partition relative (I guess > that's what grub-emu forgets) > > 2) it normalizes offset to be less than the sector size > > 3) it verifies that the range is inside the partition.
Thanks, I made a comment for it based on your description. -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
