On Tue, 2008-04-15 at 14:32 -0400, Chris Knadle wrote: > On Tuesday 15 April 2008, Robert Millan wrote: > > On Tue, Apr 15, 2008 at 12:22:48AM +0200, Lubomir Kundrak wrote: > > > --- grub-1.96.orig/util/update-grub_lib.in 2008-04-15 > > > 00:16:12.000000000 > > > +0200 +++ grub-1.96/util/update-grub_lib.in 2008-04-15 > > > 00:15:04.000000000 > > > +0200 @@ -115,6 +115,8 @@ grub_file_is_not_garbage () > > > if test -f "$1" ; then > > > case "$1" in > > > *.dpkg-dist|*.dpkg-old|*.dpkg-tmp) return 1 ;; # debian dpkg > > > + *.rpmnew|*.rpmsave) return 1 ;; # Fedora rpm > > > + *.bak|*~|.*.swp) return 1 ;; # backup and swap files from > > > editors > > > > This has the side-effect that Linux images whose name ends with ~ are > > excluded, which is probably not that uncommon. E.g. > > /boot/vmlinuz-2.6.24.foobar~ > > > > Is this really what we want?
Not uncommon; well -- I've never seen that, nor heard about if as being a custom -- but it might be just that have not seen enough. > I don't know of any localversion policy requiring that the last character > not be a tilde character. I think the localversion policy doesn't forbid the names ending with .dpkg-dist or .bak as well. > However, I can say that 'fakeroot make-kpkg > kernel_image' fails at the very last stage during making a .deb if the last > character in the localversion ends in a tilde. i.e. you can't build a > kernel "the Debian way" that has a localversion ending in a tilde. > > dpkg-gencontrol: error: Illegal package name `linux-image-2.6.24.4-yee~' > make[1]: *** [debian/linux-image-2.6.24.4-yee~] Error 255 I'm fairly sure rpm doesn't allow this too. -- Lubomir Kundrak (Red Hat Security Response Team) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
