Robert Millan schrieb:
I find that too unreliable. How do you reproduce current behaviour with
the command "grub-probe -t fs /dev/sda1" ?
I don't see the problem. Why should this be unreliable?
If the device does not exist, grub-probe will throw a "cannot stat /dev/sda1"
error with and without the patch. If the device does exist, grub-probe will
throw a "cannot find device for /dev/sda1" error without the patch and will
return "ext2" with the patch applied.
See the following examples (I have /dev/hda1, but not /dev/sda1):
Patched grub-probe:
# grub-probe -t fs /dev/sda1
grub-probe: error: cannot stat /dev/sda1.
# grub-probe -t fs /dev/hda1
ext2
Current grub-probe:
# grub-probe -t fs /dev/sda1
grub-probe: error: Cannot stat `/dev/sda1'
# grub-probe -t fs /dev/hda1
grub-probe: error: cannot find a device for /dev/hda1.
I'd prefer exposed user options than hidden behaviour like this one.
I still don't see the problem. The program will behave absolutely predictable:
If the argument is a block device it will print the device's file system. If the
argument is a valid path, it will prints the corresponding device's file system.
If the argument is none of both, it will throw an error.
Cheers,
Fabian
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
