On Wed, Feb 13, 2008 at 06:40:14PM +0800, Bean wrote: > On Feb 13, 2008 3:36 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13, 2008 at 02:47:30AM +0800, Bean wrote: > > > + /* ... and put our return address in its place (the kernel will > > > ignore > > > + it, but it expects %esp to point to it. */ > > > + call *%eax > > > > Unmatched parenthesis here (sorry I guess that's my fault ;-)). > > Ok. I also fix the alloc magic broken problem, it's caused by > grub_elf_file, which will close the file when the elf magic is not > found. However, the upper level still use that file, that cause the > memory problem. > > The patch should be applied after the previous bsd.diff.
You forgot the ChangeLog entry.. > --- a/loader/multiboot2.c > +++ b/loader/multiboot2.c > @@ -371,6 +371,7 @@ grub_multiboot2 (int argc, char *argv[]) > } > else > { > + grub_errno = 0; > grub_dprintf ("loader", "Loading non-ELF multiboot 2 file.\n"); > > if (header) Why this? -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel