Quoting Robert Millan <[EMAIL PROTECTED]>:
On Sat, Jan 26, 2008 at 06:28:23PM -0500, Pavel Roskin wrote:
- return ALIGN_UP(_end, GRUB_MOD_ALIGN);
+ return ALIGN_UP(_end + GRUB_MOD_GAP, GRUB_MOD_ALIGN);
Did you check if the requirement is just a bigger alignment rather than
a gap?
Yes, I checked that. I wish it would be bigger alignment, but it's not.
_end is 0x29NNN, so the module base 0x32000 is OK, but 0x31000 or
0x30000 is not OK. 0x30000 is better aligned than 0x32000.
I also tried adding more code to the core image, and the 0x8000 gap
was still OK.
We could increase GRUB_MOD_ALIGN, say, to 0x40000 (256k), but we could
eventually hit the limit for the code and have this problem again.
I'll rather add a couple of lines and avoid a problem that could
re-appear suddenly and for no obvious reason.
Of course, we would be very unlikely to hit a higher limit, like
0x100000 (1Mb). After all, 640k should be enough for everyone ;-)
It's your call.
--
Regards,
Pavel Roskin
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
