On Sunday 23 December 2007 22:09, Robert Millan wrote: > This patch adds a nice looking colored menu like the one you'd obtain on > GRUB Legacy with "color cyan/blue white/blue" command. Screenshot is > attached as well. > > A pair of notes: > > - The *_setcolor function stubs are being removed from some terminals > because grub_setcolor() from kernel already skips undefined *_setcolor > implementations so there's no need for an empty stub. In fact, not > needed for this patch but adds confusion (I had to inspect all them to see > if *_getcolor() had to be added). > > - I know that hardcoding colors is not so nice, but I was unsure how > would the selection interface have to look like (and lacking time to > implement it), and in comparison with defaulting to hardcoded 0x07 (grey on > black) I see it as an improvement.
I still prefer to keep the default as it is. I like that a user (or a distributor) would modify the colors in grub.cfg. Anyway, this will be a temporary hack, right? I'd love to see a fancier interface built in. Mmh, I really need to allocate time to implement one... Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
