Robert Millan wrote: > On Tue, Nov 06, 2007 at 11:33:44PM +0200, Vesa Jääskeläinen wrote: >>> * term/i386/pc/serial.c (serial_hw_put): Switch order of >>> arguments >>> in grub_outb() calls. >> Why on earth those parameters are reversed anyway :) ? > > My fault :-) > > When I replaced inb() and outb() in that file, I assumed they would have > the same semantics as grub_inb() and grub_outb().
Just to be clear, I would have understood your rational ordering better than current version ;) > grub_inb() and grub_outb() are based on the inb()/outb() implementation > from glibc headers, so I kept the same arguments for consistency. I see... Once again inconsistency introduced by Unix folks... as AT&T assembler wouldn't be enough, they then poisons C libs too... oh well... another thing to try to keep in mind... _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
