On Sat, Jun 23, 2007 at 02:32:47PM +0200, Marco Gerards wrote:
>
> You forgot a changelog entry :-/
How about..
* conf/i386-pc.rmk: (pkgdata_MODULES): Add serial.mod.
> > diff -ur grub2-1.95+20070621.old/conf/i386-pc.rmk
> > grub2-1.95+20070621/conf/i386-pc.rmk
> > --- grub2-1.95+20070621.old/conf/i386-pc.rmk 2007-06-11
> > 08:26:18.000000000 +0200
> > +++ grub2-1.95+20070621/conf/i386-pc.rmk 2007-06-23 13:56:12.000000000
> > +0200
> > @@ -91,7 +91,7 @@
> > commands/terminal.c commands/ls.c commands/test.c \
> > commands/search.c commands/blocklist.c \
> > commands/i386/pc/halt.c commands/i386/pc/reboot.c \
> > - commands/i386/cpuid.c \
> > + commands/i386/cpuid.c term/i386/pc/serial.c \
>
> Why do you add it to grub-emu? This is wrong because you can't access
> the hardware from grub-emu.
Oops.
> The same is true for cpuid, I think. Are
> you sure it works in grub-emu?
Yes, cpuid should work everywhere as long as your cpu supports it.
> Please test if it still builds, when
> adding stuff.
Sure (I even tested that it runs and sets up the serial console correctly).
> > disk/loopback.c disk/raid.c disk/lvm.c \
> > fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \
> > fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \
> > @@ -131,7 +131,7 @@
> > pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \
> > _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod \
> > vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \
> > - videotest.mod play.mod bitmap.mod tga.mod cpuid.mod
> > + videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod
>
> Good catch, I also wonder why this wasn't added. Can you please apply
> this change?
Done.
--
Robert Millan
My spam trap is [EMAIL PROTECTED] Note: this address is only intended
for spam harvesters. Writing to it will get you added to my black list.
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
