On Sun, 2007-03-25 at 00:53 +0900, 小関 一志 wrote:
> Hello, all.
>
> I write a patch for GRUB 1.95. this is able to run GRUB2 under NEC PC-9800
> series. (NEC PC-9800 is Japanese i386 computer, but its hardware design is
> different
> with PC.)
>
> Attach file: grub-1.95-nec98.diff.gz (113Kbytes)
Thanks for your hard work!
You seem to have copied many files from i386/pc to i386/nec. A better
approach would be to share them directly, for example by moving them to
the i386 directory.
Could you separate your changes to common code (e.g. the code movement
above, get_diskinfo, etc) and post those patches separately? That way we
don't have a 650KB (!!!) patch to review.
The code movement patch should just be a list of
old location -> new location
(that way it doesn't take up much space at all :) .
-Hollis
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
