Vincent Pelletier <[EMAIL PROTECTED]> writes:
Hi Vincent,
Thanks for your patch. It looks ok to me. A few small comments...
> 2005-06-29 Vincent Pelletier <[EMAIL PROTECTED]>
>
> * commands/cmp.c
> (grub_cmd_cmp): Close the right file at the right time. Compare
> only data just read. Don't report files of different size as
> identical. (BLOCK_SIZE): New macro.
The (BLOCK_SIZE) stuff should be put on a new line.
I think BUFFER_SIZE would be a better name. Another size can be
used. Perhaps it is better to use a bigger buffer size?
>
> if (grub_file_size (file1) != grub_file_size (file2))
> - grub_printf ("Differ in size: %d [%s], %d [%s]\n",
> - grub_file_size (file1), args[0],
> - grub_file_size (file2), args[1]);
> + {
> + grub_printf ("Differ in size: %d [%s], %d [%s]\n",
> + grub_file_size (file1), args[0],
> + grub_file_size (file2), args[1]);
> + }
Huh?
Thanks,
Marco
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
